fix: expand source policy extension coverage - #159
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Expands the shared source-policy scanner from TypeScript-only files to executable JavaScript and TypeScript module sources under
src/, then updates the policy test and design wording to describe that bundleable source surface consistently.Requirement UIDs
Related Issues
Closes #152
ADR Impact
Changes
SOURCE_POLICY_EXTENSIONSinventory andwalkSourceFiles()helper that includes JS, JSX, MJS, CJS, TSX, MTS, and CTS while excluding declaration files.src/**/*.ts.Test Plan
Unit tests pass (
make test)Integration tests pass if applicable (
make integration)make checkpasses (Spotless, SpotBugs, Error Prone, Checkstyle, JaCoCo)No coverage regression
pre-commit run --all-filespnpm lint && pnpm typecheck && pnpm testCodex review cycle: clean
Test-quality review reported a weak assertion class; the assertions were tightened before push, with local completion gate green.
Ground Control Checks
make policypassesgc_evaluate_quality_gatespasses or is unchanged by this repo-only changegc_run_sweepreviewed; findings fixed or recorded with rationaleTraceability
Checklist
docs/CODING_STANDARDS.md)@Auditedon new entities if applicablechangelog.d/152.fixed.md